[Kde-pim] [patch] vcard parser bugfix

[Kevin Krammer]

Hi Martin,

On Saturday 27 December 2008, Martin Koller wrote:
> Hi all,
>
> working on the kdepim-sync opensync plugin, I found that the vcard
> parsing in KDE is still broken w.r.t. time parsing of the ISO-8601
> spec. ( http://en.wikipedia.org/wiki/ISO_8601#Times ) as it does not
> respect the possibility of the basic format (without the ":" delimiter)
> and the possibility to only have the minutes and seconds optional.

Looks good.
There could be a conflict if the VCard spec specifically restrict which 
ISO-8601 formatting variants are supported.
However, since this is for parsing, it might still be OK to be more flexible 
on input and just make sure output is conforming to spec restrictions (if 
there are any)

Tobias?

> The attached patch tries to fix that, but I could not test it up till
> now as I first wanted to make a standard test for it, but I stumble
> over the tests as they are implemented now.
>
> Can someone tell me how the current tests located in
> kdepimlibs/kabc/vcardparser/tests can be run ?

See kdepimlibs/kabc/vcardparser/README.testing

> Another question I have is regarding KDE4 and PIM itself:
> I'm still running KDE3 and the opensync-plugin I fixed now is still
> using all KDE3 libs (kabc, libkcal).
> Is this supposed to stay in KDE4(.2) this way, or will the libs go away
> in favor of akonadi ?

Akonadi mostly changes the dataflow between storage and applications. 
Parsing/formatting and datatypes are still handled by the respective 
facilities of the specialized libs, e.g. using KABC::Addressee for contact 
objects or KCal::Incidenence subclasses for calendar objects.

> So does it make any sense to make the opensync kdepim plugin also run
> for KDE4 with the current implementation/libs ?

I guess this depends on how much work this would be.
The work on the Akonadi based OpenSync plugin has been temporaily halted due 
to the OpenSync 0.4 release being postponed.

Depending on how long this release is being delayed, it might be considerable 
to add some syncing on traditional resources.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20081229/e2ff10fa/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/