[Kde-pim] [Patch]KMail crashes in the configure filters dialog (trunk)

[Thomas McGuire]

Hi,

> > > This patch fixes that by using a pointer again.
> >
> > -    Resource *resource( const QString& type, const KConfigGroup &group =
> > KConfigGroup(0,0) );
> > +    Resource *resource( const QString& type, const KConfigGroup *group =
> > 0 );
> >
> > I would rather omit the default value and add a second method:
> >
> > -    Resource *resource( const QString& type, const KConfigGroup &group =
> > KConfigGroup(0,0) );
> > +    Resource *resource( const QString& type, const KConfigGroup &group);
> > +    Resource *resource( const QString& type);
> >
> > That avoids the unnecessary pointer.
>
> Yes, but then you need two resource() methods, which means code
> duplication. But if you prefer that, I'll change that, just tell me.
Actually, I've done that now, see attached patch. It still uses a pointer 
internally, but there really is no way to avoid this without producing code 
duplication.

So, Someone In Charge should now commit whichever version of the patch he 
likes better.

Thanks,
Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepimlibs-pointer.patch
Type: text/x-diff
Size: 2831 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070331/a239f1b1/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepim.patch
Type: text/x-diff
Size: 633 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070331/a239f1b1/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepimlibs-twomethods.patch
Type: text/x-diff
Size: 3139 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070331/a239f1b1/attachment-0002.patch>
-------------- next part --------------
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/