[Kde-pim] ebn fixes: pass-by-value function args

[Ingo Klöcker]

On Monday 11 June 2007 20:34, Bernhard Breinbauer wrote:
> On Sunday 10 June 2007 wrote Ingo Klöcker:
> > On Tuesday 05 June 2007 20:42, Bernhard Breinbauer wrote:
> > > Attached is a patch that (hopefully) fixes the pass-by-value
> > > issues found by krazy.
> > > Please review and commit, if it's ok.
> >
> > Thanks a bunch for this huge patch. In principal the patch looks
> > good, but there are a few caveats:
> > a) The signature changes must not break method-overloading, i.e.
> > the signature changes must be applied to all occurrences of the
> > methods in the whole class hierarchy. Otherwise those changes will
> > break polymorphism.
> >
> > b) If the signature of a slot is changed the signature of the
> > signal this slot is connected to must also be changed.
>
> OK. Second try on my first patch :-)
> I went through all my changes and checked the points mentioned above.
> Hope I got it right, please review. Especially the signal/slots part,
> as I'm still relatively new to the Qt stuff.

Excellent. AFAICS you forgot only
      SubscriptionDialog( QWidget *parent,
                          const QString &caption,
                          KAccount* acct,
                          QString startPath = QString() );
in subscriptiondialog.h.

I have committed your patch. You might want to apply for an svn-account 
(http://techbase.kde.org/Contribute/Get_a_SVN_Account) so that you can 
commit your next changes yourself.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070611/79d850c7/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/