[Kde-pim] ebn fixes: pass-by-value function args

Bernhard Breinbauer infopipe at gmx.net
Mon Jun 11 19:34:09 BST 2007


On Sunday 10 June 2007 wrote Ingo Klöcker:
> On Tuesday 05 June 2007 20:42, Bernhard Breinbauer wrote:
> > Attached is a patch that (hopefully) fixes the pass-by-value issues
> > found by krazy.
> > Please review and commit, if it's ok.
>
> Thanks a bunch for this huge patch. In principal the patch looks good,
> but there are a few caveats:
> a) The signature changes must not break method-overloading, i.e. the
> signature changes must be applied to all occurrences of the methods in
> the whole class hierarchy. Otherwise those changes will break
> polymorphism.
>
> b) If the signature of a slot is changed the signature of the signal
> this slot is connected to must also be changed.

OK. Second try on my first patch :-)
I went through all my changes and checked the points mentioned above. Hope I 
got it right, please review. Especially the signal/slots part, as I'm still 
relatively new to the Qt stuff.

best regards,
bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pass-by-value2.patch
Type: text/x-diff
Size: 62765 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070611/e88f67c6/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070611/e88f67c6/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/


More information about the kde-pim mailing list