[Kde-pim] kdepimlibs/kabc/addressbook: Question on cleanup, possible bug

[Tobias Koenig]

On Tue, Aug 28, 2007 at 02:09:39AM +0200, Kevin Krammer wrote:
> Hi,
Hi Kevin,

> - AddressBook has operators for QDataStream but doesn't do anything in there 
> (part of the code is commented out). Can they be removed or should they be 
> documented as "Empty implementation, currently does nothing"
They should stay, however as they access private d-pointer members we
have to make sure that all compilers accept it.

> - there is a method called deleteRemovedAddressees() and its body says "No 
> longer needed". Can this be removed?
Yes

> - in AddressBook::resourceSavingFinished() (line 865) the given resource is 
> removed from the list of resources pending for loading. Probably a bug, 
> should be removed from d->mPendingSaveResources?
Oops, yes of course :)

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070828/311b74a8/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/