[Kde-pim] kdepimlibs/kabc/addressbook: Question on cleanup, possible bug

[Kevin Krammer]

Hi,

I am currently trying to fix the API dox issues for kdepimlibs/kabc reported 
on EBN.

So far I have encountered three interesting things:

- AddressBook has operators for QDataStream but doesn't do anything in there 
(part of the code is commented out). Can they be removed or should they be 
documented as "Empty implementation, currently does nothing"

- there is a method called deleteRemovedAddressees() and its body says "No 
longer needed". Can this be removed?

- in AddressBook::resourceSavingFinished() (line 865) the given resource is 
removed from the list of resources pending for loading. Probably a bug, 
should be removed from d->mPendingSaveResources?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070828/103c02c6/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/