[Kde-pim] Disabling signing after saving a draft

[Till Adam]

Alexis,

On Tuesday 21 August 2007 16:05, Alexis Papadopoulos wrote:

> thank you very much for the feedback. Indeed, the choice of using the state
> headers wasn't wise, and since it was my first contact with the code, I
> didn't feel comfortable with adding new ones. Now it sure seems better that
> way.
>
> However, there is a small issue with your fix. If "never encrypt to self"
> is unchecked, you will not set your *ActionEnabled headers since you can
> rely on the *State ones, from what I understand. This means that here :
>
> // if these headers are present, the state of the message should be
> overruled mLastSignActionState = (mMsg->headerField(
> "X-KMail-SignatureActionEnabled" ) == "true");
> mLastEncryptActionState = (mMsg->headerField(
> "X-KMail-EncryptActionEnabled" ) == "true");
>
> You should first check to see if these headerFields do exist (in this case
> they don't, since never encrypt to self is unchecked), therefore you
> disable signature and encryption.

Right, my thinking was header not present -> false, but that might indeed 
override stuff which is not intended.

> I'm attaching a patch, although the fix is rather straightforward. Your
> commits were not apparently made on the 3.5 branch on which I'm working.
> Could you please also include them, so that they are part of the next
> stable release (this is why I deemed usefull to provide with the patch too)
> ?

Thanks for that. I think Volker backported the fix already, to 3.5, but I'll 
check again. I'll commit your change to all relevant branches. :)

Cheers,

Till

-- 
Till Adam -- till at kdab.net, adam at kde.org
KDAB, Platform-independent software solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070821/36b6affa/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/