Comparing KHTML in Quanta and Konq

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 29 May 2003 14:45, Carsten Pfeiffer wrote:
> On Thursday 29 May 2003 13:46, Waldo Bastian wrote:
> > This code looks very broken. It checks for objId() == saveId in
> > notifyHistoryEntry() but it seems to forget that objId is only unique for
> > a give dcop client and, as far as I can see, objId() will always return
> > "KonqHistoryManager".
> >
> > Instead, it should compare dcopClient()->appId() with
> > dcopClient()->senderId. (See patch)
>
> Indeed. Can you move this into a method isSenderOfBroadcast() or something
> like that and commit?
>
> > I also noticed that notifyHistoryEntry gets called up to 4 times for a
> > single URL, probably due to caption changes or something. Not emitting
> > emitAddToHistory for pending entries would help there, as would delaying
> > the actual saving a little with a timer (500ms or so?).
>
> But that would defeat part of the purpose of the history. E.g. you visit a
> URL and konq crashes while parsing/rendering, whatever. You don't want to
> search where you got the original URL from, you want to get it from the
> history.
>
> OTOH, there is this crash-plugin now. I never tested it tho.

The page that caused the offending link would still be in the history then.

> Maybe it would suffice to compare the timestamps. Save only the first
> pending entry and the confirming entry, but no updates in between (are
> there really any, or is this due to redirections?`).

I think you normally get two, one when the opening of the link starts and one 
when it is finished. When I go to www.kde.org I get 4, the two extra ones 
seem to be caused by the redirection from http://www.kde.org to 
http://www.kde.org/

In both cases half of the entries have pending=true

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SuSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE+1hEJN4pvrENfboIRApxNAJ9dhepKdsS0IG+5gujRphMFoW8yLQCcCK9X
0tW9MJUxIKYyvrbCOHyPFS0=
=IfPv
-----END PGP SIGNATURE-----