Comparing KHTML in Quanta and Konq

[Carsten Pfeiffer]

-----BEGIN PGP SIGNED MESSAGE-----

On Thursday 29 May 2003 15:54, Waldo Bastian wrote:

> > > I also noticed that notifyHistoryEntry gets called up to 4 times for a
> > > single URL, probably due to caption changes or something. Not emitting
> > > emitAddToHistory for pending entries would help there, as would
> > > delaying the actual saving a little with a timer (500ms or so?).
> >
> > But that would defeat part of the purpose of the history. E.g. you visit
> > a URL and konq crashes while parsing/rendering, whatever. You don't want
> > to search where you got the original URL from, you want to get it from
> > the history.
> >
> > OTOH, there is this crash-plugin now. I never tested it tho.
>
> The page that caused the offending link would still be in the history then.

If you wait for the page to be completed before the history is being saved, 
how would that work?

> > Maybe it would suffice to compare the timestamps. Save only the first
> > pending entry and the confirming entry, but no updates in between (are
> > there really any, or is this due to redirections?`).
>
> I think you normally get two, one when the opening of the link starts and
> one when it is finished. When I go to www.kde.org I get 4, the two extra
> ones seem to be caused by the redirection from http://www.kde.org to
> http://www.kde.org/
>
> In both cases half of the entries have pending=true

That case could be handled separately (see patch). Are there any other 
protocols where we can assume a redirection when the path is empty?

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPtaIb6WgYMJuwmZtAQHK9gf+Ibw+mTniL1j//tTii2yfXrgucQzB+q+w
cYvxSfinD9KSiYnHglFF3G7TdhnQJJmmkb3VodyaTOSqr8zTIvQglh4n9MHraVt3
XtN2og9tWFLsb1PLKR786Eb+cBb9YnqKZC0dFW+0Y1AMv6/9h80SctGcVexDLaIC
Rn3qmeyiNBcwuAUQD4PIGjzP0f3DECIejyz2T453HXyGHlu5bqILgfum+1v/3Ex7
Q4Y2Y6VOMKIJS8easwY3bhElMTNpf5W6C0DHljdW1yXL630Nzhr0gjgxZtmydi4r
yaKMHVRvRpyPtox9xN/X33+cgtohhQxuCe5rf6GabTQWEtEb3hIhow==
=F0Lx
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-diff
Size: 999 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-optimize/attachments/20030530/4da89687/patch.bin