Review Request 120313: Do not keep trying to open KWallet if we failed before

Jan Grulich jgrulich at redhat.com
Mon Sep 22 08:52:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120313/
-----------------------------------------------------------

Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Repository: plasma-nm


Description
-------

In the secret agent, if any of functions for processing secrets fails to open KWallet, then m_wallet will be always set to 0, which leads again to another attempt to open KWallet. We should check if opening of KWallet failed before and do not try to open it again, which should be done in my patch.

BUG: https://bugs.kde.org/show_bug.cgi?id=339223


Diffs
-----

  kded/secretagent.h a438191 
  kded/secretagent.cpp 77438ca 

Diff: https://git.reviewboard.kde.org/r/120313/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140922/c434302c/attachment.html>


More information about the kde-networkmanager mailing list