Review Request 120313: Do not keep trying to open KWallet if we failed before

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120313/#review67184
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Zář. 22, 2014, 10:52 dop., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120313/
> -----------------------------------------------------------
> 
> (Updated Zář. 22, 2014, 10:52 dop.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> In the secret agent, if any of functions for processing secrets fails to open KWallet, then m_wallet will be always set to 0, which leads again to another attempt to open KWallet. We should check if opening of KWallet failed before and do not try to open it again, which should be done in my patch.
> 
> BUG: https://bugs.kde.org/show_bug.cgi?id=339223
> 
> 
> Diffs
> -----
> 
>   kded/secretagent.h a438191 
>   kded/secretagent.cpp 77438ca 
> 
> Diff: https://git.reviewboard.kde.org/r/120313/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140922/7899b072/attachment.html>