Review Request 120145: Directly connect transfer rate label to the engine
Kai Uwe Broulik
kde at privat.broulik.de
Thu Sep 11 15:00:07 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120145/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 3 p.m.)
Status
------
This change has been marked as submitted.
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
Instead of using onNewData this patch makes the label directly connect to the data engine and this makes everything work like magic. Also gets rid of a minor overhead by not having two properties stored.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 0e24bef
Diff: https://git.reviewboard.kde.org/r/120145/diff/
Testing
-------
Works like before.
The dataengine doesn't have a forceReload() method, however, which means that we cannot have it refresh it in the instance you open the plasmoid but it always takes 2 seconds to update but that's not in the scope of this patch.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140911/1bc02db5/attachment.html>
More information about the kde-networkmanager
mailing list