Review Request 120145: Directly connect transfer rate label to the engine

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120145/#review66272
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Grulich


On Zář. 11, 2014, 2:53 odp., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120145/
> -----------------------------------------------------------
> 
> (Updated Zář. 11, 2014, 2:53 odp.)
> 
> 
> Review request for Network Management and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Instead of using onNewData this patch makes the label directly connect to the data engine and this makes everything work like magic. Also gets rid of a minor overhead by not having two properties stored.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ConnectionItem.qml 0e24bef 
> 
> Diff: https://git.reviewboard.kde.org/r/120145/diff/
> 
> 
> Testing
> -------
> 
> Works like before.
> 
> The dataengine doesn't have a forceReload() method, however, which means that we cannot have it refresh it in the instance you open the plasmoid but it always takes 2 seconds to update but that's not in the scope of this patch.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140911/b67f99db/attachment.html>