Review Request: Fix crash on editing connections from KCM network module

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101366/#review3338
-----------------------------------------------------------


This review has been submitted with commit 9243bb94e9735fdd51dccfe9598ce521d5f5c259 by Ilia Kats.

- Commit


On May 15, 2011, 7:03 a.m., Rajeesh K Nambiar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101366/
> -----------------------------------------------------------
> 
> (Updated May 15, 2011, 7:03 a.m.)
> 
> 
> Review request for Network Management and Lamarque Vieira Souza.
> 
> 
> Summary
> -------
> 
> Commit 89e8f1999cca60 incorrectly set typeString instead of type in restore[User]Connections. This causes editClicked not to be able to determine the correct connection type from QTreeWidget->item->data(0,ConnectionTypeRole). Fix by using connection type itself.
> 
> 
> Diffs
> -----
> 
>   settings/config/manageconnectionwidget.cpp 68157ea 
> 
> Diff: http://git.reviewboard.kde.org/r/101366/diff
> 
> 
> Testing
> -------
> 
> Tested with KDE SC 4.6.3 and latest git snapshot of plasma-networkmanagement
> 
> 
> Thanks,
> 
> Rajeesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110515/ca8a686a/attachment.htm