Review Request: Fix crash on editing connections from KCM network module

Rajeesh K Nambiar rajeeshknambiar at gmail.com
Sun May 15 09:03:31 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101366/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.


Summary
-------

Commit 89e8f1999cca60 incorrectly set typeString instead of type in restore[User]Connections. This causes editClicked not to be able to determine the correct connection type from QTreeWidget->item->data(0,ConnectionTypeRole). Fix by using connection type itself.


Diffs
-----

  settings/config/manageconnectionwidget.cpp 68157ea 

Diff: http://git.reviewboard.kde.org/r/101366/diff


Testing
-------

Tested with KDE SC 4.6.3 and latest git snapshot of plasma-networkmanagement


Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110515/0ae43c0f/attachment.htm 


More information about the kde-networkmanager mailing list