Review Request: various fixes for adhoc support

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101158/#review2754
-----------------------------------------------------------



applet/activatablelistwidget.cpp
<http://git.reviewboard.kde.org/r/101158/#comment2415>

    use qobject_cast instead of dynamic_cast for classes with Q_OBJECT macro, it is faster.



libs/internals/wirelessinterfaceconnectionhelpers.cpp
<http://git.reviewboard.kde.org/r/101158/#comment2416>

    qobject_cast



libs/ui/802_11_wirelesswidget.cpp
<http://git.reviewboard.kde.org/r/101158/#comment2417>

    Why remove those two lines?


- Lamarque Vieira


On April 19, 2011, 8:08 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101158/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 8:08 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> Various fixes for adhoc support. These include:
> - don't show the network we just created twice (once as connection and once as network)
> - show correct security icon for adhoc networks
> - only show strenghtmeter if strength >=0
> - unconnected adhoc networks are now only visible after a click on "Show More...", are always visible if connected and become invisible again after disconnecting
> 
> 
> Diffs
> -----
> 
>   applet/activatableitem.cpp 860b421 
>   applet/activatablelistwidget.h 2e16db3 
>   applet/activatablelistwidget.cpp 63fb8c4 
>   applet/wirelessnetworkitem.cpp 86a7246 
>   libs/internals/settings/802-11-wireless-securitypersistence.cpp ef93f2c 
>   libs/internals/wirelessinterfaceconnectionhelpers.cpp 55d8527 
>   libs/service/wirelessnetworkinterfaceactivatableprovider.cpp 482727d 
>   libs/ui/802_11_wirelesswidget.cpp af67199 
> 
> Diff: http://git.reviewboard.kde.org/r/101158/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Ilia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110419/ef6983d9/attachment.htm