Review Request: various fixes for adhoc support

[Ilia Kats]

> On April 19, 2011, 9:18 p.m., Lamarque Vieira Souza wrote:
> > libs/internals/wirelessinterfaceconnectionhelpers.cpp, line 121
> > <http://git.reviewboard.kde.org/r/101158/diff/1/?file=14772#file14772line121>
> >
> >     qobject_cast

Knm::Setting and its child classes do not use the Q_OBJECT macro, so no qobject_cast here


> On April 19, 2011, 9:18 p.m., Lamarque Vieira Souza wrote:
> > libs/ui/802_11_wirelesswidget.cpp, line 110
> > <http://git.reviewboard.kde.org/r/101158/diff/1/?file=14774#file14774line110>
> >
> >     Why remove those two lines?

band and channel only matter for adhoc connections, and are handled in lines 87/88. Actually, the d->ui.channel->setValue(d->setting->channel()); line did not show the channel correctly, as channels are stored as their numerical values (1-13 for b/g and all the other stuff for a), while the QSpinBox expects a zero-based index, so d->ui.channel->posFromChannel(d->setting->channel()); should be used in any case.


- Ilia


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101158/#review2754
-----------------------------------------------------------


On April 19, 2011, 8:08 p.m., Ilia Kats wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101158/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 8:08 p.m.)
> 
> 
> Review request for Network Management.
> 
> 
> Summary
> -------
> 
> Various fixes for adhoc support. These include:
> - don't show the network we just created twice (once as connection and once as network)
> - show correct security icon for adhoc networks
> - only show strenghtmeter if strength >=0
> - unconnected adhoc networks are now only visible after a click on "Show More...", are always visible if connected and become invisible again after disconnecting
> 
> 
> Diffs
> -----
> 
>   applet/activatableitem.cpp 860b421 
>   applet/activatablelistwidget.h 2e16db3 
>   applet/activatablelistwidget.cpp 63fb8c4 
>   applet/wirelessnetworkitem.cpp 86a7246 
>   libs/internals/settings/802-11-wireless-securitypersistence.cpp ef93f2c 
>   libs/internals/wirelessinterfaceconnectionhelpers.cpp 55d8527 
>   libs/service/wirelessnetworkinterfaceactivatableprovider.cpp 482727d 
>   libs/ui/802_11_wirelesswidget.cpp af67199 
> 
> Diff: http://git.reviewboard.kde.org/r/101158/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Ilia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110419/b6cf97e4/attachment-0001.htm