<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101158/">http://git.reviewboard.kde.org/r/101158/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101158/diff/1/?file=14769#file14769line158" style="color: black; font-weight: bold; text-decoration: underline;">applet/activatablelistwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool ActivatableListWidget::accept(RemoteActivatable * activatable) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">RemoteWirelessInterfaceConnection</span> <span class="o">*</span> <span class="n">wic</span> <span class="o">=</span> <span class="k">dynamic_cast</span><span class="o"><</span><span class="n">RemoteWirelessInterfaceConnection</span><span class="o">*></span><span class="p">(</span><span class="n">activatable</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use qobject_cast instead of dynamic_cast for classes with Q_OBJECT macro, it is faster.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101158/diff/1/?file=14772#file14772line121" style="color: black; font-weight: bold; text-decoration: underline;">libs/internals/wirelessinterfaceconnectionhelpers.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void WirelessInterfaceConnectionBuilder::init(WirelessInterfaceConnection *ic)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">120</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Knm</span><span class="o">::</span><span class="n">WirelessSecuritySetting</span> <span class="o">*</span> <span class="n">wirelessSecuritySetting</span> <span class="o">=</span> <span class="k">dynamic_cast</span><span class="o"><</span><span class="n">Knm</span><span class="o">::</span><span class="n">WirelessSecuritySetting</span> <span class="o">*></span><span class="p">(</span><span class="n">m_connection</span><span class="o">-></span><span class="n">setting</span><span class="p">(</span><span class="n">Knm</span><span class="o">::</span><span class="n">Setting</span><span class="o">::</span><span class="n">WirelessSecurity</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">qobject_cast</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101158/diff/1/?file=14774#file14774line110" style="color: black; font-weight: bold; text-decoration: underline;">libs/ui/802_11_wirelesswidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Wireless80211Widget::readConfig()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">110</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">ui</span><span class="p">.</span><span class="n">band</span><span class="o">-></span><span class="n">setCurrentIndex</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">setting</span><span class="o">-></span><span class="n">band</span><span class="p">());</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why remove those two lines?</pre>
</div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On April 19th, 2011, 8:08 p.m., Ilia Kats wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management.</div>
<div>By Ilia Kats.</div>
<p style="color: grey;"><i>Updated April 19, 2011, 8:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Various fixes for adhoc support. These include:
- don't show the network we just created twice (once as connection and once as network)
- show correct security icon for adhoc networks
- only show strenghtmeter if strength >=0
- unconnected adhoc networks are now only visible after a click on "Show More...", are always visible if connected and become invisible again after disconnecting</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/activatableitem.cpp <span style="color: grey">(860b421)</span></li>
<li>applet/activatablelistwidget.h <span style="color: grey">(2e16db3)</span></li>
<li>applet/activatablelistwidget.cpp <span style="color: grey">(63fb8c4)</span></li>
<li>applet/wirelessnetworkitem.cpp <span style="color: grey">(86a7246)</span></li>
<li>libs/internals/settings/802-11-wireless-securitypersistence.cpp <span style="color: grey">(ef93f2c)</span></li>
<li>libs/internals/wirelessinterfaceconnectionhelpers.cpp <span style="color: grey">(55d8527)</span></li>
<li>libs/service/wirelessnetworkinterfaceactivatableprovider.cpp <span style="color: grey">(482727d)</span></li>
<li>libs/ui/802_11_wirelesswidget.cpp <span style="color: grey">(af67199)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101158/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>