Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/#review94671
-----------------------------------------------------------


Ship it!




Ship It!

- Harald Sitter


On April 17, 2016, 6:51 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127672/
> -----------------------------------------------------------
> 
> (Updated April 17, 2016, 6:51 p.m.)
> 
> 
> Review request for kdewin and Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> s_pulseActive is used inside PulseSupport::isUsable but is declared under HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this method to always return false when we don't HAVE_PULSEAUDIO.
> 
> 
> Diffs
> -----
> 
>   phonon/pulsesupport.cpp dd79204 
> 
> Diff: https://git.reviewboard.kde.org/r/127672/diff/
> 
> 
> Testing
> -------
> 
> It builds on windows after this patch, no further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160417/4dd103c1/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia