Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef
Andrius da Costa Ribas
andriusmao-Re5JQEeQqe8AvxtiuMwx3w at public.gmane.org
Sun Apr 17 19:51:40 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/
-----------------------------------------------------------
Review request for kdewin and Phonon.
Repository: phonon
Description
-------
s_pulseActive is used inside PulseSupport::isUsable but is declared under HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this method to always return false when we don't HAVE_PULSEAUDIO.
Diffs
-----
phonon/pulsesupport.cpp dd79204
Diff: https://git.reviewboard.kde.org/r/127672/diff/
Testing
-------
It builds on windows after this patch, no further testing done.
Thanks,
Andrius da Costa Ribas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160417/ca9aca96/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-windows mailing list
Kde-windows at kde.org
https://mail.kde.org/mailman/listinfo/kde-windows
More information about the kde-multimedia
mailing list