Review Request 127672: declare s_pulseActive outside HAVE_PULSEAUDIO ifdef

[Andrius da Costa Ribas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127672/
-----------------------------------------------------------

(Updated April 17, 2016, 7:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdewin and Phonon.


Changes
-------

Submitted with commit 92adeaf2851a1f94ea3b3cdfdf3e6b27394d2a53 by Andrius da Costa Ribas to branch master.


Repository: phonon


Description
-------

s_pulseActive is used inside PulseSupport::isUsable but is declared under HAVE_PULSEAUDIO ifdef. Another solution would be creating an ifdef inside this method to always return false when we don't HAVE_PULSEAUDIO.


Diffs
-----

  phonon/pulsesupport.cpp dd79204 

Diff: https://git.reviewboard.kde.org/r/127672/diff/


Testing
-------

It builds on windows after this patch, no further testing done.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160417/873c8357/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia