Review Request 127130: [Dragon] Working preview

Anthony Fieroni bvbfan at abv.bg
Sat Apr 16 12:19:23 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127130/
-----------------------------------------------------------

(Updated Април 16, 2016, 2:19 след обяд)


Review request for KDE Multimedia, David Edmundson and Harald Sitter.


Changes
-------

We want to not toggle view when pause state is executed
Expected behavior:
- playing
- click on play media
- continues playing
- manually pause
- stay in load view
- unpause again
- you are now dropped to videoView again


Repository: dragon


Description
-------

toggleLoadView in video mode not stop playback and even make 'blink' mainview frame


Diffs (updated)
-----

  src/app/mainWindow.cpp 777467b 
  src/app/stateChange.cpp c9f2528 

Diff: https://git.reviewboard.kde.org/r/127130/diff/


Testing
-------

Now preview works correctly.


File Attachments
----------------

Screenshot_20160328_223543.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/28/2280d4bb-75f8-4f84-aa50-e857fe84a99b__Screenshot_20160328_223543.png


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160416/648af138/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list