Review Request 127130: [Dragon] Working preview

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127130/#review94678
-----------------------------------------------------------


Fix it, then Ship it!




I'd reduce the stateChange.cpp change to only an else if instead of using a whole new variable. Realistically we only ever want to toggle on Playing really.


src/app/stateChange.cpp (line 88)
<https://git.reviewboard.kde.org/r/127130/#comment64339>

    You could simply make this 
    ```
    else if (state == Phonon::Playing)
    ````
    to achive the same end result without having to introduce the toggleView variable at all.


- Harald Sitter


On April 16, 2016, 11:19 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127130/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 11:19 a.m.)
> 
> 
> Review request for KDE Multimedia, David Edmundson and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> toggleLoadView in video mode not stop playback and even make 'blink' mainview frame
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.cpp 777467b 
>   src/app/stateChange.cpp c9f2528 
> 
> Diff: https://git.reviewboard.kde.org/r/127130/diff/
> 
> 
> Testing
> -------
> 
> Now preview works correctly.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160328_223543.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/28/2280d4bb-75f8-4f84-aa50-e857fe84a99b__Screenshot_20160328_223543.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160418/77e6c473/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia