Review Request 127130: [Dragon] Working preview

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127130/#review94637
-----------------------------------------------------------



I think the intention was that when one goes to the loadView the video is paused and only the thumbnail is shown. I am rather indifferent though, so simply letting it continue playing is fine by me as well.

To have this work correctly you have to adjust the MainWindow::engineStateChanged loadView toggle to only run on state == Playing though.

With the proposed patch the behavior is somewhat weird:
- playing
- click on play media
- continues playing
- manually pause
- dropped back to videoView

I think what should be is:
- playing
- click on play media
- continues playing
- manually pause
- dragon stays on load view

Changinge the engineStateChanged behavior to only work on playing is still a bit unfortunate though. In particular in the use case:
- playing
- click on play media
- continues playing
- manually pause
- stay in load view
- unpause again
- you are now dropped to videoView again

I think it's fine because the way I see it one would pause the video because one got annoyed or bored with it and wants to look for something else instead, so the only scenario where one would unpause it again while being in loadView is because one didn't find anything better, at which point one would have to continue watching the current video anyway.

So yeah, please change engineStateChanged to only toggle on playing and this is going to be perfect.

- Harald Sitter


On March 28, 2016, 7:41 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127130/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 7:41 p.m.)
> 
> 
> Review request for KDE Multimedia, David Edmundson and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> toggleLoadView in video mode not stop playback and even make 'blink' mainview frame
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.cpp 777467b 
> 
> Diff: https://git.reviewboard.kde.org/r/127130/diff/
> 
> 
> Testing
> -------
> 
> Now preview works correctly.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot_20160328_223543.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/28/2280d4bb-75f8-4f84-aa50-e857fe84a99b__Screenshot_20160328_223543.png
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20160415/2fbcb7d6/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia