Review Request 125350: add new audiooutputinterface signal for 4.9 to propagate muteness changes

Harald Sitter sitter at
Wed Sep 23 08:40:29 BST 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 23, 2015, 7:40 a.m.)

Review request for Phonon and Daniel Vrátil.


I also added some interface ifing to

- if the interface is implemented phonon will not emit mutedChanged but let the backend drive it (to make the signal actually async)
- if the interface is not implemented the signals will not be connected to avoid warnings coming out of qt

Repository: phonon


as all other interfaces this is an opt-in interface revision. backends
need to mute into this by building with -DPHONON_BACKEND_VERSION_4_9

muteness always had frontend API but was lacking backend API to allow the
backend to drive muteness changes in a reactive manner. this in particular
will allow us to stop using pulsesupport in pvlc and pgst as they can now
drive muteness which previously was only provided by the pulsesupport
overlay class.

Diffs (updated)

  phonon/audiooutput.cpp f118824f99b5c9dda0bff63c5de578bbae40bf28 
  phonon/audiooutputinterface.h ca9c30a72253ac994c03ec35a178f23765f825df 



builds and seems to work fine in dragon with a PoC implementation for phonon vlc


Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list