Review Request 125350: add new audiooutputinterface signal for 4.9 to propagate muteness changes

Harald Sitter sitter at kde.org
Wed Sep 23 08:41:14 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125350/
-----------------------------------------------------------

(Updated Sept. 23, 2015, 7:41 a.m.)


Status
------

This change has been marked as submitted.


Review request for Phonon and Daniel Vrátil.


Changes
-------

Submitted with commit 7dc6dd822ab98f0b0424415d29660a7d36579fb0 by Harald Sitter to branch master.


Repository: phonon


Description
-------

as all other interfaces this is an opt-in interface revision. backends
need to mute into this by building with -DPHONON_BACKEND_VERSION_4_9

muteness always had frontend API but was lacking backend API to allow the
backend to drive muteness changes in a reactive manner. this in particular
will allow us to stop using pulsesupport in pvlc and pgst as they can now
drive muteness which previously was only provided by the pulsesupport
overlay class.


Diffs
-----

  phonon/audiooutput.cpp f118824f99b5c9dda0bff63c5de578bbae40bf28 
  phonon/audiooutputinterface.h ca9c30a72253ac994c03ec35a178f23765f825df 

Diff: https://git.reviewboard.kde.org/r/125350/diff/


Testing
-------

builds and seems to work fine in dragon with a PoC implementation for phonon vlc


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150923/0df03a75/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list