Review Request 125350: add new audiooutputinterface signal for 4.9 to propagate muteness changes

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125350/#review85789
-----------------------------------------------------------

Ship it!


Looks good to me

- Daniel Vrátil


On Sept. 22, 2015, 3:17 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125350/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 3:17 p.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> as all other interfaces this is an opt-in interface revision. backends
> need to mute into this by building with -DPHONON_BACKEND_VERSION_4_9
> 
> muteness always had frontend API but was lacking backend API to allow the
> backend to drive muteness changes in a reactive manner. this in particular
> will allow us to stop using pulsesupport in pvlc and pgst as they can now
> drive muteness which previously was only provided by the pulsesupport
> overlay class.
> 
> 
> Diffs
> -----
> 
>   phonon/audiooutput.cpp f118824f99b5c9dda0bff63c5de578bbae40bf28 
>   phonon/audiooutputinterface.h ca9c30a72253ac994c03ec35a178f23765f825df 
> 
> Diff: https://git.reviewboard.kde.org/r/125350/diff/
> 
> 
> Testing
> -------
> 
> builds and seems to work fine in dragon with a PoC implementation for phonon vlc
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150922/829ecd9a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia