Review Request 118545: ffmpegthumbs: Port to Frameworks

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/#review65809
-----------------------------------------------------------


Looks good, thanks!


CMakeLists.txt
<https://git.reviewboard.kde.org/r/118545/#comment45964>

    Use (BUILD_TESTING)
    You might also have to port tests/CMakeLists.txt



ffmpegthumbnailer.cpp
<https://git.reviewboard.kde.org/r/118545/#comment45965>

    Unused include



ffmpegthumbnailer/imagewriter.cpp
<https://git.reviewboard.kde.org/r/118545/#comment45966>

    Unused include



ffmpegthumbnailer/moviedecoder.cpp
<https://git.reviewboard.kde.org/r/118545/#comment45967>

    #include <QDebug>
    or #include <QtCore/QDebug> I don't know what the official guideline is.


- Maarten De Meyer


On Sept. 4, 2014, 6 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118545/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 6 p.m.)
> 
> 
> Review request for KDE Multimedia and David Faure.
> 
> 
> Repository: ffmpegthumbs
> 
> 
> Description
> -------
> 
> simple port to KF5.
> added Alex if he maybe has an idea why video/* doesn't seem to work.
> 
> 
> Diffs
> -----
> 
>   ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
>   ffmpegthumbnailer/imagewriter.cpp 7dae371 
>   CMakeLists.txt dd0974f 
>   ffmpegthumbnailer.cpp 03a40c3 
> 
> Diff: https://git.reviewboard.kde.org/r/118545/diff/
> 
> 
> Testing
> -------
> 
> Builds; thumbnails appear in Dolphin.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140904/c73fc61f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia