Review Request 118545: ffmpegthumbs: Port to Frameworks

Hrvoje Senjan hrvoje.senjan at gmail.com
Thu Sep 4 19:00:46 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/
-----------------------------------------------------------

(Updated Sept. 4, 2014, 8 p.m.)


Review request for KDE Multimedia and David Faure.


Changes
-------

drop the desktop workaround; added dependant review (Maarten reminded me on this review, and found the issue before me)


Repository: ffmpegthumbs


Description (updated)
-------

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.


Diffs (updated)
-----

  ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
  ffmpegthumbnailer/imagewriter.cpp 7dae371 
  CMakeLists.txt dd0974f 
  ffmpegthumbnailer.cpp 03a40c3 

Diff: https://git.reviewboard.kde.org/r/118545/diff/


Testing
-------

Builds; thumbnails appear in Dolphin.


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140904/c5075848/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list