Review Request 118545: ffmpegthumbs: Port to Frameworks

[Mathias Tillman]

> On Sept. 4, 2014, 7:39 p.m., Maarten De Meyer wrote:
> > ffmpegthumbnailer/moviedecoder.cpp, line 19
> > <https://git.reviewboard.kde.org/r/118545/diff/2/?file=309724#file309724line19>
> >
> >     #include <QDebug>
> >     or #include <QtCore/QDebug> I don't know what the official guideline is.

The official QT page says to just do #include <QDebug>, that's also how it's written in most places (not all).


- Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/#review65809
-----------------------------------------------------------


On Sept. 14, 2014, 9:46 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118545/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 9:46 p.m.)
> 
> 
> Review request for KDE Multimedia and David Faure.
> 
> 
> Repository: ffmpegthumbs
> 
> 
> Description
> -------
> 
> simple port to KF5.
> added Alex if he maybe has an idea why video/* doesn't seem to work.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dd0974f 
>   ffmpegthumbnailer.cpp 03a40c3 
>   ffmpegthumbnailer/imagewriter.cpp 7dae371 
>   ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
>   tests/CMakeLists.txt 5525e00 
> 
> Diff: https://git.reviewboard.kde.org/r/118545/diff/
> 
> 
> Testing
> -------
> 
> Builds; thumbnails appear in Dolphin.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140915/3bd87562/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia