Review Request 116682: Do not check credentials if either username or password is empty.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116682/#review54504
-----------------------------------------------------------


This review has been submitted with commit 1a1d6c23eb56d651e75c0ccc17b86e2930766740 by Arnold Dumas to branch master.

- Commit Hook


On March 9, 2014, 9:40 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116682/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 9:40 p.m.)
> 
> 
> Review request for KDE Multimedia and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> At the moment, the scrobbler credentials dialog allows the user to try to login even if the username or the password is empty. The dialog should only propose it when the two fields are filled in.
> 
> 
> Diffs
> -----
> 
>   scrobbleconfigdlg.cpp 7bcf19d 
> 
> Diff: https://git.reviewboard.kde.org/r/116682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140328/ed9a1f57/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia