Review Request 116682: Do not check credentials if either username or password is empty.

Arnold Dumas contact at arnolddumas.fr
Fri Mar 28 20:48:37 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116682/
-----------------------------------------------------------

(Updated March 28, 2014, 8:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia and Martin Tobias Holmedahl Sandsmark.


Repository: juk


Description
-------

At the moment, the scrobbler credentials dialog allows the user to try to login even if the username or the password is empty. The dialog should only propose it when the two fields are filled in.


Diffs
-----

  scrobbleconfigdlg.cpp 7bcf19d 

Diff: https://git.reviewboard.kde.org/r/116682/diff/


Testing
-------


Thanks,

Arnold Dumas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140328/89f14907/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list