Review Request 116682: Do not check credentials if either username or password is empty.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116682/#review54411
-----------------------------------------------------------

Ship it!


A couple of issues to iron out but should be ready from there.


scrobbleconfigdlg.cpp
<https://git.reviewboard.kde.org/r/116682/#comment38027>

    We should enable the m_testButton at this point if it can be enabled, that way the GUI reflects what can actually be clicked on.
    
    The easy (and more correct) way to make this happen is to simply call valuesChanged() here ourselves, and have that function make the needed GUI updates.
    
    Just make sure not to move the check for "button(Apply)" here to the valuesChanged() function, since the Apply button seems to be for the case when we've verified the credentials. If we have credentials stored in the wallet or config then they should have been verified previously and so we can let them be re-applied.



scrobbleconfigdlg.cpp
<https://git.reviewboard.kde.org/r/116682/#comment38028>

    Style comment: else should start a separate line, and then the m_testButton... code should itself be on a separate indented line. See HACKING for more details (I'm aware the code is not *fully* consistent but that's no reason to get further away from it).


- Michael Pyne


On March 9, 2014, 9:40 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116682/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 9:40 p.m.)
> 
> 
> Review request for KDE Multimedia and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> At the moment, the scrobbler credentials dialog allows the user to try to login even if the username or the password is empty. The dialog should only propose it when the two fields are filled in.
> 
> 
> Diffs
> -----
> 
>   scrobbleconfigdlg.cpp 7bcf19d 
> 
> Diff: https://git.reviewboard.kde.org/r/116682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140328/c7e64acb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia