Review Request 118754: Make Juk report Paused on the mpris2 interface

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118754/
-----------------------------------------------------------

(Updated June 17, 2014, 10:57 a.m.)


Review request for KDE Multimedia.


Changes
-------

The first patch was broken with GStreamer.

This revision fixes what broke, but doesn't show metadata while Juk is paused. It does however also work better with the KDE Telepathy mpris2 plugin, like Juk from 4.13.2 does.

So, leaving Juk without this patch leaves pause not properly being reported when the player is in pause, but with this patch the metadata not being displayed in the mpris2 dataengine when paused. I don't know how many people would want to trade off metadata while paused for properly reporting pause on mpris2.


Repository: juk


Description
-------

Juk doesn't advertise paused over mpris2. Emit the paused state not the playing state in case of no errors / warnings. This means all cases where the player is not playing or stopped and actually idle. This works around a bug that only seems to be present with Juk and the VLC backend.


Diffs (updated)
-----

  mpris2/mediaplayer2player.cpp 080b43f 
  playermanager.h 6c7756e 
  playermanager.cpp 975243f 

Diff: https://git.reviewboard.kde.org/r/118754/diff/


Testing
-------

Compile, run. Watch Kmix debug.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140617/e55959e8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia