Review Request 118754: Make Juk report Paused on the mpris2 interface

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118754/
-----------------------------------------------------------

(Updated June 18, 2014, 3:20 a.m.)


Review request for KDE Multimedia.


Changes
-------

The status message blanking turned out to be a regression in my installation of KTp, now identified and fixed. This patch fixes the pause state handling without changing the metadata output. So, best possible outcome with initial problem fixed.

This patch signals state change for mpris2 independent of the individual state signals. This makes pause reporting work always for the mpris2 adapter irregardless of installed Phonon backend.


Repository: juk


Description
-------

Juk doesn't advertise paused over mpris2. Emit the paused state not the playing state in case of no errors / warnings. This means all cases where the player is not playing or stopped and actually idle. This works around a bug that only seems to be present with Juk and the VLC backend.


Diffs (updated)
-----

  playermanager.cpp 975243f 
  playermanager.h 6c7756e 
  mpris2/mediaplayer2player.cpp 080b43f 

Diff: https://git.reviewboard.kde.org/r/118754/diff/


Testing
-------

Compile, run. Watch Kmix debug.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140618/08f58c0e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia