Review Request 118754: Make Juk report Paused on the mpris2 interface

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118754/#review60151
-----------------------------------------------------------

Ship it!


This looks good (and indeed, I think I've seen the Juk systray manage to get confused about whether it was paused or playing, and having a difference between updating state before or after Phonon events are received would make sense as a reason).

- Michael Pyne


On June 15, 2014, 7:57 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118754/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 7:57 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Juk doesn't advertise paused over mpris2. Emit the paused state not the playing state in case of no errors / warnings. This means all cases where the player is not playing or stopped and actually idle. This works around a bug that only seems to be present with Juk and the VLC backend.
> 
> 
> Diffs
> -----
> 
>   playermanager.cpp 975243f 
> 
> Diff: https://git.reviewboard.kde.org/r/118754/diff/
> 
> 
> Testing
> -------
> 
> Compile, run. Watch Kmix debug.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140616/96b7bd0b/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia