Review Request 110273: Juk should be able to exclude folders.

[Tom Li]

> On May 11, 2013, 11:06 p.m., Michael Pyne wrote:
> > collectionlist.cpp, line 286
> > <http://git.reviewboard.kde.org/r/110273/diff/5/?file=141828#file141828line286>
> >
> >     We can do both here since .canonicalPath() returns a new QString:
> >     
> >     // m_excludeFolders is cleared here
> >     foreach(const QString &folder, collection->excludedFolders()) {
> >         m_excludeFolders << folder.canonicalPath();
> >     }

Actually, it should be const QDir &folder, right? :)


> On May 11, 2013, 11:06 p.m., Michael Pyne wrote:
> > directorylist.cpp, line 35
> > <http://git.reviewboard.kde.org/r/110273/diff/5/?file=141830#file141830line35>
> >
> >     I didn't notice this last time because I only reviewed online, but this line uses tabs for indentation instead of spaces.
> >     
> >     This isn't a big issue as I would manually fix before applying, but it's something to watch for in existing code bases.

I use Vim all the time, I love four-space-indentation too. But this time I have to use KDevelop because I need view a lot of code, I don't know how to setup indent correctly. :(


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110273/#review32365
-----------------------------------------------------------


On May 11, 2013, 7:21 p.m., Tom Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110273/
> -----------------------------------------------------------
> 
> (Updated May 11, 2013, 7:21 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> If we add some folders to Juk's watching list, Juk will add everything
> in the folder. But sometimes, we don't want Juk to add some folders.
> There isn't a way to exclude folders.
> 
> It is bugging me all the time. I can't stand it so I starting patching
> it with a little C++ and Qt knowledge.
> 
> Here is my patch. If my patch can merge into mainline, our users
> should be happier :). I don't have much C++ experience, there are some
> hacks in my code, but that's the best what I can do. So please help me
> to improve it.
> 
> 
> This addresses bug 319106.
>     http://bugs.kde.org/show_bug.cgi?id=319106
> 
> 
> Diffs
> -----
> 
>   collectionlist.h e8c15de 
>   collectionlist.cpp f4df66b 
>   directorylist.h f13756f 
>   directorylist.cpp b715a2c 
>   directorylistbase.ui 6146726 
>   playlist.h 1fc640b 
>   playlist.cpp 2153f9b 
>   playlistcollection.h d9fd9ff 
>   playlistcollection.cpp fbb33a6 
> 
> Diff: http://git.reviewboard.kde.org/r/110273/diff/
> 
> 
> Testing
> -------
> 
> Yes, it works for me.
> But I need some help to improve the patch. Nobody reviews the new version? 
> 
> 
> Thanks,
> 
> Tom Li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130512/10014e24/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia