Review Request 110273: Juk should be able to exclude folders.

[Tom Li]

On May 11, 2013, 11:06 p.m., Tom Li wrote:
> > Overall pretty good, most (though not all) of the initially seen issues were fixed.
> > 
> > Still a couple of style issues but that's not a big deal as I can fix those.
> > 
> > I'm currently running this code as well so I can at least confirm it doesn't break JuK.
> > 
> > My only major point of concern is that it should still be possible to manually add files from an excluded folder. We just don't want to have JuK automatically search excluded folders. I'll need to review the codepaths to see if that's still an issue. If it is we can still go ahead and commit (after the issues noted in this pass are fixed) and then I can adjust to fix the new "bug" introduced before the next release.

Sure, that's the issue. If a user excluded a folders, he/she may wants to remove it from the playlist. 

I don't know how to remove a song from the playlist by a path, so I have to add a filter when list is loading. So, if the user added a song from the playlist, it will remove after Juk restarted.

Even I remove the song from the playlist instead of add a filter, every time after the user click "Ok" of the setting window, his own song from excluded folders will remove. Juk can not differentiate the song added automatically or added by the user.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110273/#review32365
-----------------------------------------------------------


On May 11, 2013, 7:21 p.m., Tom Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110273/
> -----------------------------------------------------------
> 
> (Updated May 11, 2013, 7:21 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> If we add some folders to Juk's watching list, Juk will add everything
> in the folder. But sometimes, we don't want Juk to add some folders.
> There isn't a way to exclude folders.
> 
> It is bugging me all the time. I can't stand it so I starting patching
> it with a little C++ and Qt knowledge.
> 
> Here is my patch. If my patch can merge into mainline, our users
> should be happier :). I don't have much C++ experience, there are some
> hacks in my code, but that's the best what I can do. So please help me
> to improve it.
> 
> 
> This addresses bug 319106.
>     http://bugs.kde.org/show_bug.cgi?id=319106
> 
> 
> Diffs
> -----
> 
>   collectionlist.h e8c15de 
>   collectionlist.cpp f4df66b 
>   directorylist.h f13756f 
>   directorylist.cpp b715a2c 
>   directorylistbase.ui 6146726 
>   playlist.h 1fc640b 
>   playlist.cpp 2153f9b 
>   playlistcollection.h d9fd9ff 
>   playlistcollection.cpp fbb33a6 
> 
> Diff: http://git.reviewboard.kde.org/r/110273/diff/
> 
> 
> Testing
> -------
> 
> Yes, it works for me.
> But I need some help to improve the patch. Nobody reviews the new version? 
> 
> 
> Thanks,
> 
> Tom Li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130512/ba6caed1/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia