<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110273/">http://git.reviewboard.kde.org/r/110273/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 11th, 2013, 11:06 p.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall pretty good, most (though not all) of the initially seen issues were fixed.
Still a couple of style issues but that's not a big deal as I can fix those.
I'm currently running this code as well so I can at least confirm it doesn't break JuK.
My only major point of concern is that it should still be possible to manually add files from an excluded folder. We just don't want to have JuK automatically search excluded folders. I'll need to review the codepaths to see if that's still an issue. If it is we can still go ahead and commit (after the issues noted in this pass are fixed) and then I can adjust to fix the new "bug" introduced before the next release.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, that's the issue. If a user excluded a folders, he/she may wants to remove it from the playlist.
I don't know how to remove a song from the playlist by a path, so I have to add a filter when list is loading. So, if the user added a song from the playlist, it will remove after Juk restarted.
Even I remove the song from the playlist instead of add a filter, every time after the user click "Ok" of the setting window, his own song from excluded folders will remove. Juk can not differentiate the song added automatically or added by the user.</pre>
<br />
<p>- Tom</p>
<br />
<p>On May 11th, 2013, 7:21 p.m. UTC, Tom Li wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Tom Li.</div>
<p style="color: grey;"><i>Updated May 11, 2013, 7:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we add some folders to Juk's watching list, Juk will add everything
in the folder. But sometimes, we don't want Juk to add some folders.
There isn't a way to exclude folders.
It is bugging me all the time. I can't stand it so I starting patching
it with a little C++ and Qt knowledge.
Here is my patch. If my patch can merge into mainline, our users
should be happier :). I don't have much C++ experience, there are some
hacks in my code, but that's the best what I can do. So please help me
to improve it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it works for me.
But I need some help to improve the patch. Nobody reviews the new version? </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319106">319106</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>collectionlist.h <span style="color: grey">(e8c15de)</span></li>
<li>collectionlist.cpp <span style="color: grey">(f4df66b)</span></li>
<li>directorylist.h <span style="color: grey">(f13756f)</span></li>
<li>directorylist.cpp <span style="color: grey">(b715a2c)</span></li>
<li>directorylistbase.ui <span style="color: grey">(6146726)</span></li>
<li>playlist.h <span style="color: grey">(1fc640b)</span></li>
<li>playlist.cpp <span style="color: grey">(2153f9b)</span></li>
<li>playlistcollection.h <span style="color: grey">(d9fd9ff)</span></li>
<li>playlistcollection.cpp <span style="color: grey">(fbb33a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110273/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>