Review Request: dbus also don't like // (avoid another crash)

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107439/#review22524
-----------------------------------------------------------

Ship it!


It looks like a similar dbus crash fix has already been committed to master. The rest of the patch looks correct to me (and compiles and works fine here) but I don't delve into kmix often so hopefully one of their devs will see this and review. If not within a day or so, you can go ahead and commit on my recommendation.

- Michael Pyne


On Nov. 23, 2012, 8:26 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107439/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 8:26 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Initialize two member variables in the constructor.
> Translate // into /
> change a duplicated variable check
> remove a clang warning
> 
> 
> Diffs
> -----
> 
>   backends/mixer_mpris2.cpp 0bf9152 
>   core/mixdevice.cpp 693f083 
>   gui/guiprofile.cpp 3e68d43 
>   gui/ksmallslider.cpp 03caaab 
>   gui/mdwslider.cpp 872526d 
> 
> Diff: http://git.reviewboard.kde.org/r/107439/diff/
> 
> 
> Testing
> -------
> 
> Before, a crash for trying to register "/Mixers//Master_0"
> After, working.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121125/88100b3b/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia