Review Request: dbus also don't like // (avoid another crash)

Jaime Torres Amate jtamate at gmail.com
Fri Nov 23 20:26:22 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107439/
-----------------------------------------------------------

Review request for KDE Multimedia.


Description
-------

Initialize two member variables in the constructor.
Translate // into /
change a duplicated variable check
remove a clang warning


Diffs
-----

  backends/mixer_mpris2.cpp 0bf9152 
  core/mixdevice.cpp 693f083 
  gui/guiprofile.cpp 3e68d43 
  gui/ksmallslider.cpp 03caaab 
  gui/mdwslider.cpp 872526d 

Diff: http://git.reviewboard.kde.org/r/107439/diff/


Testing
-------

Before, a crash for trying to register "/Mixers//Master_0"
After, working.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121123/f31edba8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list