Review Request: dbus also don't like // (avoid another crash)
Commit Hook
null at kde.org
Mon Nov 26 17:49:47 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107439/#review22587
-----------------------------------------------------------
This review has been submitted with commit b40bb6caff90252912df3d2c84ca76a664159384 by Jaime Torres to branch master.
- Commit Hook
On Nov. 23, 2012, 8:26 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107439/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2012, 8:26 p.m.)
>
>
> Review request for KDE Multimedia.
>
>
> Description
> -------
>
> Initialize two member variables in the constructor.
> Translate // into /
> change a duplicated variable check
> remove a clang warning
>
>
> Diffs
> -----
>
> backends/mixer_mpris2.cpp 0bf9152
> core/mixdevice.cpp 693f083
> gui/guiprofile.cpp 3e68d43
> gui/ksmallslider.cpp 03caaab
> gui/mdwslider.cpp 872526d
>
> Diff: http://git.reviewboard.kde.org/r/107439/diff/
>
>
> Testing
> -------
>
> Before, a crash for trying to register "/Mixers//Master_0"
> After, working.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121126/e4bb281e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list