[PATCH] juk: save collection list cache on exit

[Michael Pyne]

On Thursday, June 09, 2011 15:47:02 Γιώργος Κυλάφας wrote:
> 2011/6/8 Michael Pyne <mpyne at kde.org>:
> > Well I believe the code prior to the Phonon backend crash workaround was
> > much as you have it in your patch, which means it should at least work.
> > If it's working better for you in your testing then I'd say go for it.
> > It's easily possible for me to never notice the bug you're talking
> > about here: a) I always use the quit action to exit JuK, and b) my
> > music folder is always re-scanned anyways.
> 
> Question: why is your music folder always re-scanned? I mean, is it
> because the cache is not saved, just like it was happening to me? In
> which case, does the patch solve this for you?
> Or is it something else?

No, JuK loads the cache just fine, the rescanning happens because I keep my 
music folder in JuK's folder list (File -> Add Folders), which JuK scans at 
startup for music.

Existing cached items have their tags read from disk again, but that's a 
separate issue (short story is that CollectionListItem::refresh is called 
during startup for each track, which ends up calling QFileInfo::refresh() for 
each FileHandle).

Either way given that Phonon does not crash during shutdown I have no 
objection to removing the slotPlaybackStopped() workaround.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110609/30be51a9/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia