[PATCH] juk: save collection list cache on exit

[Γιώργος Κυλάφας (Giorgos Kylafas)]

2011/6/8 Michael Pyne <mpyne at kde.org>:
> Well I believe the code prior to the Phonon backend crash workaround was much
> as you have it in your patch, which means it should at least work. If it's
> working better for you in your testing then I'd say go for it. It's easily
> possible for me to never notice the bug you're talking about here: a) I always
> use the quit action to exit JuK, and b) my music folder is always re-scanned
> anyways.

Question: why is your music folder always re-scanned? I mean, is it
because the cache is not saved, just like it was happening to me? In
which case, does the patch solve this for you?
Or is it something else?

> I'll note that merely calling m_player->stop() wasn't good enough when I wrote
> that workaround: Phonon really had to settle into the StoppedState, which was
> what the slotPlaybackStopped() slot was supposed to wait for. In my opinion
> the backend if broken if that's actually an issue at shutdown so I don't have
> any strong objection to that slot being removed, but I do want to be clear
> that it is not "dead code".

Yes, I understand. However, I could not have used
slotPlaybackStopped() from inside queryExit(), since quit() has
already been called. This did not seem to harm anything, so I removed
the slot completely.

I decided to test some more, though.
slotPlaybackStopped() was introduced in r921339 (before 4.3 beta1). I
checked this revision out and tested it, but JuK would still crash on
exit, albeit for a different reason. That crash was fixed in r1054429
(before 4.4 beta1), so I checked this out instead, and removed
slotPlaybackStopped() to see what happens. Well, JuK did not crash on
exit any more. So, I guess there was at some point a change in Phonon
which made the wait for StoppedState unnecessary.

In the end, I think it should be better to split the patch in two, one
for the cache and one for the crash, and commit both. If the latter
does not work for all users, we could still revert only it.

Regards,

-- 
Γιώργος Κυλάφας (Giorgos Kylafas)
http://en.wikipedia.org/wiki/Posting_style#Inline_replying
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia