[PATCH] juk: save collection list cache on exit

[Michael Pyne]

On Tuesday, June 07, 2011 14:31:24 Γιώργος Κυλάφας wrote:
> I have been testing the above change for the last few days and the
> collection list cache is always saved/restored properly. :-)
> 
> However, in case 2 (closing the window), JuK crashes if it is playing
> a file at the time, with or without the change.
> On retrospect, this is reasonable since the cause of the crash is only
> dealt with in JuK::slotQuit, which is not executed when closing the
> JuK window.
> 
> So, I updated the patch to the one attached here. With this version,
> the cache is saved/restored properly and I experience no crashes no
> matter how I exit the application.
> 
> However, I would like a second opinion before committing this. At the
> least, I am thinking whether it should be broken up to two patches,
> one dealing with the crash and the other with the cache saving.

Well I believe the code prior to the Phonon backend crash workaround was much 
as you have it in your patch, which means it should at least work. If it's 
working better for you in your testing then I'd say go for it. It's easily 
possible for me to never notice the bug you're talking about here: a) I always 
use the quit action to exit JuK, and b) my music folder is always re-scanned 
anyways.

I'll note that merely calling m_player->stop() wasn't good enough when I wrote 
that workaround: Phonon really had to settle into the StoppedState, which was 
what the slotPlaybackStopped() slot was supposed to wait for. In my opinion 
the backend if broken if that's actually an issue at shutdown so I don't have 
any strong objection to that slot being removed, but I do want to be clear 
that it is not "dead code".

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110607/6b7105b1/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia