Review Request: AvCapture test-app: show a warning if the path between the AvCapture-object and the output node cannot be created

[Martin Blumenstingl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100459/#review1122
-----------------------------------------------------------

Ship it!


apachelogger gave his "OK" on IRC.

committed: http://commits.kde.org/b61c3b2b/493cefccb2ca4797ecad4b5bc92f1056caad9c60

- Martin


On Jan. 30, 2011, 2:15 a.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100459/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2011, 2:15 a.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Summary
> -------
> 
> I was trying out phonon's audio recording capabilities.
> Thus I tried to get any sound with the avcaptureapptest.
> 
> Unfortunately Arch Linux' phonon-vlc backend is not compiled with "experimental" support.
> Thus it could never have worked.
> 
> Unfortunately the user does not see that his backend does not support AvCapturing.
> Only a warning on the command line (WARNING: Phonon::createPath: Cannot connect  Phonon::Experimental::AvCapture ( no objectName ) to  Phonon::AudioOutput ( no objectName ).) indicates that there's something wrong.
> 
> With my patch a warning is shown if the path could not be created.
> 
> 
> Diffs
> -----
> 
>   phonon/experimental/tests/avcaptureapptest/capture_test.cpp 35f3c3c 
> 
> Diff: http://git.reviewboard.kde.org/r/100459/diff
> 
> 
> Testing
> -------
> 
> The test application still starts.
> The warning is shown if phonon-vlc is compiled without experimental support.
> The warning is not shown if it is compiled with experimental support.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110130/2e782273/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia