<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100459/">http://git.reviewboard.kde.org/r/100459/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">apachelogger gave his "OK" on IRC.
committed: http://commits.kde.org/b61c3b2b/493cefccb2ca4797ecad4b5bc92f1056caad9c60</pre>
<br />
<p>- Martin</p>
<br />
<p>On January 30th, 2011, 2:15 a.m., Martin Blumenstingl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon.</div>
<div>By Martin Blumenstingl.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2011, 2:15 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was trying out phonon's audio recording capabilities.
Thus I tried to get any sound with the avcaptureapptest.
Unfortunately Arch Linux' phonon-vlc backend is not compiled with "experimental" support.
Thus it could never have worked.
Unfortunately the user does not see that his backend does not support AvCapturing.
Only a warning on the command line (WARNING: Phonon::createPath: Cannot connect Phonon::Experimental::AvCapture ( no objectName ) to Phonon::AudioOutput ( no objectName ).) indicates that there's something wrong.
With my patch a warning is shown if the path could not be created.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test application still starts.
The warning is shown if phonon-vlc is compiled without experimental support.
The warning is not shown if it is compiled with experimental support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>phonon/experimental/tests/avcaptureapptest/capture_test.cpp <span style="color: grey">(35f3c3c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>