[PATCH]: juk: tageditor: refresh contents when the collection gets updated.

Michael Pyne mpyne at kde.org
Mon Apr 25 02:53:18 BST 2011

On Wednesday, April 20, 2011 18:25:45 Γιώργος Κυλάφας wrote:
> Hi all,
> I am not sure this is the optimal/correct fix for this behavior,
> however it seems to be working fine so far. :-)

Your analysis of this issue seems correct, and your suggested fix meshes with 
the actual behavior elsewhere (specifically in the TagEditor::showEvent() 
method which handles some of the work from slotUpdateCollection if the tag 
editor is not actually visible).

I would prefer that the correct functionality of updateCollection() does not 
depend on always calling slotRefresh() right afterward though and so I will be 
changing the code to simply call slotRefresh() from updateCollection() 
assuming it passes testing. ;)

 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20110424/f5148b4f/attachment.sig>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at kde.org

More information about the kde-multimedia mailing list