[KDE/Mac] Review Request 121992: Add Battery energyFull and energyFullDesign

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121992/#review73884
-----------------------------------------------------------

Ship it!


I applied the patch on OSX/CI and it BUILD FINE. (I didn't do any other tests so far, though.)

- Marko Käning


On Jan. 12, 2015, 4:35 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121992/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 4:35 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> To properly calculate cumulative values we need to know the actual Wh values of the batteries (deducing it from the current energy and percentage or capacity produces significant rounding errors).
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/backends/fakehw/fakebattery.h 3066f24 
>   src/solid/devices/backends/fakehw/fakebattery.cpp f90cb76 
>   src/solid/devices/backends/hal/halbattery.h 0d91009 
>   src/solid/devices/backends/hal/halbattery.cpp 24dde4b 
>   src/solid/devices/backends/iokit/iokitbattery.h ccf6b20 
>   src/solid/devices/backends/upower/upowerbattery.h 0f0c7b6 
>   src/solid/devices/backends/upower/upowerbattery.cpp 7c1689e 
>   src/solid/devices/backends/win/winbattery.h 5dfe7c7 
>   src/solid/devices/backends/win/winbattery.cpp 95dbbb3 
>   src/solid/devices/frontend/battery.h 4c3c3f7 
>   src/solid/devices/frontend/battery.cpp 7b95fc9 
>   src/solid/devices/ifaces/battery.h 055af62 
> 
> Diff: https://git.reviewboard.kde.org/r/121992/diff/
> 
> 
> Testing
> -------
> 
> energyFull and energyFullDesign report correct values on UPower here. I implemented it for HAL and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150112/5e0df444/attachment.html>