<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121992/">https://git.reviewboard.kde.org/r/121992/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I applied the patch on OSX/CI and it BUILD FINE. (I didn't do any other tests so far, though.)</p></pre>
<br />
<p>- Marko Käning</p>
<br />
<p>On January 12th, 2015, 4:35 p.m. CET, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2015, 4:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To properly calculate cumulative values we need to know the actual Wh values of the batteries (deducing it from the current energy and percentage or capacity produces significant rounding errors).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">energyFull and energyFullDesign report correct values on UPower here. I implemented it for HAL and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/devices/backends/fakehw/fakebattery.h <span style="color: grey">(3066f24)</span></li>
<li>src/solid/devices/backends/fakehw/fakebattery.cpp <span style="color: grey">(f90cb76)</span></li>
<li>src/solid/devices/backends/hal/halbattery.h <span style="color: grey">(0d91009)</span></li>
<li>src/solid/devices/backends/hal/halbattery.cpp <span style="color: grey">(24dde4b)</span></li>
<li>src/solid/devices/backends/iokit/iokitbattery.h <span style="color: grey">(ccf6b20)</span></li>
<li>src/solid/devices/backends/upower/upowerbattery.h <span style="color: grey">(0f0c7b6)</span></li>
<li>src/solid/devices/backends/upower/upowerbattery.cpp <span style="color: grey">(7c1689e)</span></li>
<li>src/solid/devices/backends/win/winbattery.h <span style="color: grey">(5dfe7c7)</span></li>
<li>src/solid/devices/backends/win/winbattery.cpp <span style="color: grey">(95dbbb3)</span></li>
<li>src/solid/devices/frontend/battery.h <span style="color: grey">(4c3c3f7)</span></li>
<li>src/solid/devices/frontend/battery.cpp <span style="color: grey">(7b95fc9)</span></li>
<li>src/solid/devices/ifaces/battery.h <span style="color: grey">(055af62)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>